Re: [PATCH 3/4] RDMA/siw: Remove kmap()

From: Jason Gunthorpe
Date: Thu Jul 15 2021 - 14:00:44 EST


On Mon, Jun 21, 2021 at 11:14:21PM -0700, ira.weiny@xxxxxxxxx wrote:
> From: Ira Weiny <ira.weiny@xxxxxxxxx>
>
> kmap() is being deprecated and will break uses of device dax after PKS
> protection is introduced.[1]
>
> These uses of kmap() in the SIW driver are thread local. Therefore
> kmap_local_page() is sufficient to use and will work with pgmap
> protected pages when those are implemnted.
>
> There is one more use of kmap() in this driver which is split into its
> own patch because kmap_local_page() has strict ordering rules and the
> use of the kmap_mask over multiple segments must be handled carefully.
> Therefore, that conversion is handled in a stand alone patch.
>
> Use kmap_local_page() instead of kmap() in the 'easy' cases.
>
> [1] https://lore.kernel.org/lkml/20201009195033.3208459-59-ira.weiny@xxxxxxxxx/
>
> Signed-off-by: Ira Weiny <ira.weiny@xxxxxxxxx>
> ---
> drivers/infiniband/sw/siw/siw_qp_tx.c | 14 ++++++++------
> 1 file changed, 8 insertions(+), 6 deletions(-)

Applied to for-next, thanks

Jason