Re: [PATCH v1] arm64: dts: imx8qm: added System MMU

From: Oliver Graute
Date: Thu Jul 15 2021 - 04:47:22 EST


On 14/07/21, Robin Murphy wrote:
> On 2021-07-14 13:09, Oliver Graute wrote:
> > added node for System MMU
>
> Note that it's a bit of a dangerous game to enable an SMMU without the
> complete Stream ID topology for *all* its upstream devices also described,
> since CONFIG_ARM_SMMU_DISABLE_BYPASS_BY_DEFAULT will ruin peoples' day. It
> might be more polite to add it in a disabled state until every "iommus"
> property has been filled in, so that people who do want to play with it for
> specific devices in the meantime can easily just flip the status (while
> taking the necessary precautions), but people who don't care won't be
> inadvertently affected regardless of their kernel config. I'm assuming an
> SMMU with 32 contexts has more than a single USB controller behind it...

thx for the explanation. So I will set this node to disabled state in
next version of this patch.
>
> > };
> > + smmu: iommu@51400000 {
> > + compatible = "arm,mmu-500";
> > + interrupt-parent = <&gic>;
> > + reg = <0 0x51400000 0 0x40000>;
> > + #global-interrupts = <1>;
> > + #iommu-cells = <2>;
> > + interrupts = <0 32 4>,
> > + <0 32 4>, <0 32 4>, <0 32 4>, <0 32 4>,
> > + <0 32 4>, <0 32 4>, <0 32 4>, <0 32 4>,
> > + <0 32 4>, <0 32 4>, <0 32 4>, <0 32 4>,
> > + <0 32 4>, <0 32 4>, <0 32 4>, <0 32 4>,
> > + <0 32 4>, <0 32 4>, <0 32 4>, <0 32 4>,
> > + <0 32 4>, <0 32 4>, <0 32 4>, <0 32 4>,
> > + <0 32 4>, <0 32 4>, <0 32 4>, <0 32 4>,
> > + <0 32 4>, <0 32 4>, <0 32 4>, <0 32 4>;
status = "disabled";
> > + };

Best regards,

Oliver