[PATCH 01/13] spi: spi-mem: Add DTR templates for cmd, address, dummy and data phase

From: Apurva Nandan
Date: Tue Jul 13 2021 - 09:06:13 EST


Setting dtr field of spi_mem_op is useful when creating templates
for DTR ops in spinand.h. Also, 2 bytes cmd phases are required when
operating in Octal DTR SPI mode.

Create new templates for dtr mode cmd, address, dummy and data phase
in spi_mem_op, which set the dtr field to 1 and also allow passing
the nbytes for the cmd phase.

Signed-off-by: Apurva Nandan <a-nandan@xxxxxx>
---
include/linux/spi/spi-mem.h | 87 ++++++++++++++++++++++++++-----------
1 file changed, 61 insertions(+), 26 deletions(-)

diff --git a/include/linux/spi/spi-mem.h b/include/linux/spi/spi-mem.h
index 85e2ff7b840d..73e52a3ecf66 100644
--- a/include/linux/spi/spi-mem.h
+++ b/include/linux/spi/spi-mem.h
@@ -13,46 +13,81 @@

#include <linux/spi/spi.h>

-#define SPI_MEM_OP_CMD(__opcode, __buswidth) \
- { \
- .buswidth = __buswidth, \
- .opcode = __opcode, \
- .nbytes = 1, \
+#define SPI_MEM_OP_CMD_ALL_ARGS(__nbytes, __opcode, __buswidth, __dtr) \
+ { \
+ .buswidth = __buswidth, \
+ .opcode = __opcode, \
+ .nbytes = __nbytes, \
+ .dtr = __dtr, \
}

-#define SPI_MEM_OP_ADDR(__nbytes, __val, __buswidth) \
- { \
- .nbytes = __nbytes, \
- .val = __val, \
- .buswidth = __buswidth, \
+#define SPI_MEM_OP_CMD(__opcode, __buswidth) \
+ SPI_MEM_OP_CMD_ALL_ARGS(1, __opcode, __buswidth, 0)
+
+#define SPI_MEM_OP_CMD_DTR(__nbytes, __opcode, __buswidth) \
+ SPI_MEM_OP_CMD_ALL_ARGS(__nbytes, __opcode, __buswidth, 1)
+
+#define SPI_MEM_OP_ADDR_ALL_ARGS(__nbytes, __val, __buswidth, __dtr) \
+ { \
+ .nbytes = __nbytes, \
+ .val = __val, \
+ .buswidth = __buswidth, \
+ .dtr = __dtr, \
}

+#define SPI_MEM_OP_ADDR(__nbytes, __val, __buswidth) \
+ SPI_MEM_OP_ADDR_ALL_ARGS(__nbytes, __val, __buswidth, 0)
+
+#define SPI_MEM_OP_ADDR_DTR(__nbytes, __val, __buswidth) \
+ SPI_MEM_OP_ADDR_ALL_ARGS(__nbytes, __val, __buswidth, 1)
+
#define SPI_MEM_OP_NO_ADDR { }

-#define SPI_MEM_OP_DUMMY(__nbytes, __buswidth) \
- { \
- .nbytes = __nbytes, \
- .buswidth = __buswidth, \
+#define SPI_MEM_OP_DUMMY_ALL_ARGS(__nbytes, __buswidth, __dtr) \
+ { \
+ .nbytes = __nbytes, \
+ .buswidth = __buswidth, \
+ .dtr = __dtr, \
}

+#define SPI_MEM_OP_DUMMY(__nbytes, __buswidth) \
+ SPI_MEM_OP_DUMMY_ALL_ARGS(__nbytes, __buswidth, 0)
+
+#define SPI_MEM_OP_DUMMY_DTR(__nbytes, __buswidth) \
+ SPI_MEM_OP_DUMMY_ALL_ARGS(__nbytes, __buswidth, 1)
+
#define SPI_MEM_OP_NO_DUMMY { }

-#define SPI_MEM_OP_DATA_IN(__nbytes, __buf, __buswidth) \
- { \
- .dir = SPI_MEM_DATA_IN, \
- .nbytes = __nbytes, \
- .buf.in = __buf, \
- .buswidth = __buswidth, \
+#define SPI_MEM_OP_DATA_IN_ALL_ARGS(__nbytes, __buf, __buswidth, __dtr) \
+ { \
+ .dir = SPI_MEM_DATA_IN, \
+ .nbytes = __nbytes, \
+ .buf.in = __buf, \
+ .buswidth = __buswidth, \
+ .dtr = __dtr, \
}

-#define SPI_MEM_OP_DATA_OUT(__nbytes, __buf, __buswidth) \
- { \
- .dir = SPI_MEM_DATA_OUT, \
- .nbytes = __nbytes, \
- .buf.out = __buf, \
- .buswidth = __buswidth, \
+#define SPI_MEM_OP_DATA_IN(__nbytes, __buf, __buswidth) \
+ SPI_MEM_OP_DATA_IN_ALL_ARGS(__nbytes, __buf, __buswidth, 0)
+
+#define SPI_MEM_OP_DATA_IN_DTR(__nbytes, __buf, __buswidth) \
+ SPI_MEM_OP_DATA_IN_ALL_ARGS(__nbytes, __buf, __buswidth, 1)
+
+#define SPI_MEM_OP_DATA_OUT_ALL_ARGS(__nbytes, __buf, __buswidth, __dtr)\
+ { \
+ .dir = SPI_MEM_DATA_OUT, \
+ .nbytes = __nbytes, \
+ .buf.out = __buf, \
+ .buswidth = __buswidth, \
+ .dtr = __dtr, \
}

+#define SPI_MEM_OP_DATA_OUT(__nbytes, __buf, __buswidth) \
+ SPI_MEM_OP_DATA_OUT_ALL_ARGS(__nbytes, __buf, __buswidth, 0)
+
+#define SPI_MEM_OP_DATA_OUT_DTR(__nbytes, __buf, __buswidth) \
+ SPI_MEM_OP_DATA_OUT_ALL_ARGS(__nbytes, __buf, __buswidth, 1)
+
#define SPI_MEM_OP_NO_DATA { }

/**
--
2.17.1