Re: [PATCH v10 8/8] PCI: Change the type of probe argument in reset functions

[Alex Williamson]

On Fri,  9 Jul 2021 18:08:13 +0530
Amey Narkhede <ameynarkhede03@xxxxxxxxx> wrote:

> Introduce a new enum pci_reset_mode_t to make the context of probe argument
> in reset functions clear and the code easier to read.  Change the type of
> probe argument in functions which implement reset methods from int to
> pci_reset_mode_t to make the intent clear.
> 
> Add a new line in return statement of pci_reset_bus_function().
> 
> Suggested-by: Alex Williamson <alex.williamson@xxxxxxxxxx>
> Suggested-by: Krzysztof Wilczyński <kw@xxxxxxxxx>
> Signed-off-by: Amey Narkhede <ameynarkhede03@xxxxxxxxx>
> ---
>  drivers/crypto/cavium/nitrox/nitrox_main.c    |  2 +-
>  .../ethernet/cavium/liquidio/lio_vf_main.c    |  2 +-
>  drivers/pci/hotplug/pciehp.h                  |  2 +-
>  drivers/pci/hotplug/pciehp_hpc.c              |  4 +-
>  drivers/pci/hotplug/pnv_php.c                 |  4 +-
>  drivers/pci/pci-acpi.c                        | 10 ++-
>  drivers/pci/pci-sysfs.c                       |  6 +-
>  drivers/pci/pci.c                             | 85 ++++++++++++-------
>  drivers/pci/pci.h                             | 12 +--
>  drivers/pci/pcie/aer.c                        |  2 +-
>  drivers/pci/quirks.c                          | 37 ++++----
>  include/linux/pci.h                           |  8 +-
>  include/linux/pci_hotplug.h                   |  2 +-
>  13 files changed, 107 insertions(+), 69 deletions(-)

Reviewed-by: Alex Williamson <alex.williamson@xxxxxxxxxx>