Re: [PATCH][RESEND] Revert "PM: ACPI: reboot: Use S5 for reboot"

[Kai-Heng Feng]

On Sat, Mar 20, 2021 at 12:23 AM Kai-Heng Feng
<kai.heng.feng@xxxxxxxxxxxxx> wrote:
>
> On Fri, Mar 19, 2021 at 3:02 AM Josef Bacik <josef@xxxxxxxxxxxxxx> wrote:
> >
> > On 3/18/21 1:42 AM, Kai-Heng Feng wrote:
> > > On Thu, Mar 18, 2021 at 1:25 AM Josef Bacik <josef@xxxxxxxxxxxxxx> wrote:
> > > [snipped]
> > >> "shutdown now" works fine with and without your patch.  Thanks,
> > >
> > > Rafael,
> > > Please revert the patch while we are working on it.
> > >
> > > Josef,
> > > Can you please test the following patch:
> > >
> >
> > That made it work fine.  Thanks,
>
> So there are things depend on reboot or shutdown to carry out
> different behaviors.
> Can you please find whether there is any code path uses SYSTEM_RESTART
> or SYSTEM_POWER_OFF that leads to different behavior? Most likely
> happen in a driver's .shutdown callback.

A gentle ping...

>
> Kai-Heng
>
> >
> > Josef