Re: [PATCH v4 3/3] iommu: dart: Add DART iommu driver

From: Alyssa Rosenzweig
Date: Mon Jul 12 2021 - 09:53:26 EST


> > Should we be checking alignment here? Something like
> >
> > BUG_ON(paddr & ((1 << DART_TTBR_SHIFT) - 1));
> >
>
> Sure, right now paddr will always be aligned but adding that
> BUG_ON doesn't hurt :)

Probably should have suggested WARN_ON instead of BUG_ON but yes.