Re: [PATCH v2 06/31] EDAC/amd64: Define Data Fabric operations

From: Yazen Ghannam
Date: Thu Jul 08 2021 - 15:55:52 EST


On Wed, Jun 30, 2021 at 07:19:45PM +0200, Borislav Petkov wrote:
> On Wed, Jun 23, 2021 at 07:19:37PM +0000, Yazen Ghannam wrote:

...

> >
> > + if (set_df_ops(&ctx))
> > + return -EINVAL;
> > +
> > if (amd_df_indirect_read(nid, df_regs[DRAM_OFFSET], umc, &tmp))
> > goto out_err;
> >
> > --
>
> Why?
>
> You can simply assign to df_ops as this is all driver-static data.
>

Good point. We can set this in per_family_init().

Thanks,
Yazen