RE: [PATCH V2] remoteproc: elf_loader: fix loading segment when is_iomem true

[Peng Fan (OSS)]

Hi Bjorn,

> Subject: [PATCH V2] remoteproc: elf_loader: fix loading segment when
> is_iomem true

Would you pick up this as a fix?

Thanks,
Peng.

> 
> From: Peng Fan <peng.fan@xxxxxxx>
> 
> It seems luckliy work on i.MX platform, but it is wrong.
> Need use memcpy_toio, not memcpy_fromio.
> 
> Fixes: 40df0a91b2a52 ("remoteproc: add is_iomem to da_to_va")
> Tested-by: Dong Aisheng <aisheng.dong@xxxxxxx> (i.MX8MQ)
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Reported-by: Dong Aisheng <aisheng.dong@xxxxxxx>
> Signed-off-by: Peng Fan <peng.fan@xxxxxxx>
> ---
> 
> V2:
>  the __iomem cast should be for the 1st parameter.
> 
>  drivers/remoteproc/remoteproc_elf_loader.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/remoteproc/remoteproc_elf_loader.c
> b/drivers/remoteproc/remoteproc_elf_loader.c
> index 469c52e62faf..44e7f9308f4b 100644
> --- a/drivers/remoteproc/remoteproc_elf_loader.c
> +++ b/drivers/remoteproc/remoteproc_elf_loader.c
> @@ -220,7 +220,7 @@ int rproc_elf_load_segments(struct rproc *rproc,
> const struct firmware *fw)
>  		/* put the segment where the remote processor expects it */
>  		if (filesz) {
>  			if (is_iomem)
> -				memcpy_fromio(ptr, (void __iomem *)(elf_data + offset),
> filesz);
> +				memcpy_toio((void __iomem *)ptr, elf_data + offset,
> filesz);
>  			else
>  				memcpy(ptr, elf_data + offset, filesz);
>  		}
> --
> 2.30.0