RE: [PATCH V3 0/4] tools: perf: Add JSON metrics for i.MX8M platforms

[Joakim Zhang]

> -----Original Message-----
> From: John Garry <john.garry@xxxxxxxxxx>
> Sent: 2021年7月6日 18:06
> To: Joakim Zhang <qiangqing.zhang@xxxxxxx>; will@xxxxxxxxxx;
> mathieu.poirier@xxxxxxxxxx; leo.yan@xxxxxxxxxx; peterz@xxxxxxxxxxxxx;
> mingo@xxxxxxxxxx; acme@xxxxxxxxxx; mark.rutland@xxxxxxx;
> alexander.shishkin@xxxxxxxxxxxxxxx; jolsa@xxxxxxxxxx;
> namhyung@xxxxxxxxxx; shawnguo@xxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx
> Cc: kernel@xxxxxxxxxxxxxx; festevam@xxxxxxxxx; dl-linux-imx
> <linux-imx@xxxxxxx>; kjain@xxxxxxxxxxxxx;
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH V3 0/4] tools: perf: Add JSON metrics for i.MX8M
> platforms
> 
> On 06/07/2021 10:48, Joakim Zhang wrote:
> >> Hi Joakim,
> >>
> >> I have done some rework to the metricgroup sys event support.
> >>
> >> If you have a chance, it would be appreciated if you could test this
> >> following series for these imx8 metrics+events:
> >>
> >> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit
> >> hub.c
> >> om%2Fhisilicon%2Fkernel-dev%2Fcommits%2Fprivate-topic-perf-5.13-sys-r
> >> ewri
> >>
> te-3&amp;data=04%7C01%7Cqiangqing.zhang%40nxp.com%7Cbf35517133c3
> >>
> 48ebd58e08d940587875%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0
> >> %7C637611570992762798%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4w
> LjA
> >>
> wMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;s
> >>
> data=RzNaXZubTrhO0MRl2sD45v7Vbs1KgzRWCRymTQIJLZM%3D&amp;reser
> >> ved=0
> > Hi John,
> >
> > I only need build perf tool with above code, no need to update the kernel,
> right?
> 
> Right, just userspace perf tool needs rebuild. Same kernel which you used
> before should be ok.

Hi John,

Test env:
perf version 5.13.rc7.gf9a8701c7091
5.13.0-rc1-next-20210514

I tested on i.MX8MQ, i.MX8MM and i.MX8MP, there is no function breakage, but I have not verified metric includes "duration_time" event.

A nitpick, there is no comma at the end of "Unit".

Best Regards,
Joakim Zhang
> 
> Thanks!