[PATCH] tools: bpftool: close va_list 'ap' by va_end()

From: gushengxian
Date: Thu Jul 01 2021 - 08:00:39 EST


From: gushengxian <gushengxian@xxxxxxxxxx>

va_list 'ap' was opened but not closed by va_end(). It should be
closed by va_end() before return.

Signed-off-by: gushengxian <gushengxian@xxxxxxxxxx>
---
tools/bpf/bpftool/jit_disasm.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tools/bpf/bpftool/jit_disasm.c b/tools/bpf/bpftool/jit_disasm.c
index e7e7eee9f172..3c85fd1f00cb 100644
--- a/tools/bpf/bpftool/jit_disasm.c
+++ b/tools/bpf/bpftool/jit_disasm.c
@@ -45,8 +45,10 @@ static int fprintf_json(void *out, const char *fmt, ...)
char *s;

va_start(ap, fmt);
- if (vasprintf(&s, fmt, ap) < 0)
+ if (vasprintf(&s, fmt, ap) < 0) {
+ va_end(ap);
return -1;
+ }
va_end(ap);

if (!oper_count) {
--
2.25.1