Re: [PATCH] usb: dwc3: avoid NULL access of usb_gadget_driver

From: Alan Stern
Date: Mon Jun 28 2021 - 21:36:20 EST


On Tue, Jun 29, 2021 at 08:20:28AM +0800, Linyu Yuan wrote:
> we found crash in dwc3_disconnect_gadget(),
> it is because dwc->gadget_driver become NULL before async access.
> 7dc0c55e9f30 ('USB: UDC core: Add udc_async_callbacks gadget op')
> suggest a common way to avoid such kind of issue.
>
> this change implment the callback in dwc3 and
> change related functions which have callback to UDC core.
>
> Signed-off-by: Linyu Yuan <linyyuan@xxxxxxxxxxxxxx>
> ---

In general this looks very good, all nice and simple. But it doesn't
cover the reset callback (dwc3_reset_gadget).

Alan Stern