Re: [PATCH v2 5/5] hwmon: intel-m10-bmc-hwmon: add n5010 sensors

From: Moritz Fischer
Date: Mon Jun 28 2021 - 13:28:34 EST


Hi Guenter,

On Mon, Jun 28, 2021 at 09:35:56AM -0700, Guenter Roeck wrote:
> On Fri, Jun 25, 2021 at 09:42:13AM +0200, Martin Hundebøll wrote:
> > From: Martin Hundebøll <mhu@xxxxxxxxxx>
> >
> > Add the list of sensors supported by the Silicom n5010 PAC, and enable
> > the drivers as a subtype of the intel-m10-bmc multi-function driver.
> >
> > Signed-off-by: Martin Hundebøll <mhu@xxxxxxxxxx>
>
> For my reference:
>
> Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>
Reviewed-by: Moritz Fischer <mdf@xxxxxxxxxx>

>
> Not sure if I can apply this patch as-is to hwmon, or if it needs
> to wait for the other patches in the series. Any thoughts / comments ?

I don't see how it would break anything in itself since it just adds
extra compatible and data.

I'd probably wait with applying until discussions around the mfd and dfl
parts are resolved since otherwise there's no user.

> Guenter

Thanks,
Moritz