Re: [PATCH] net: sched: fix warning in tcindex_alloc_perfect_hash

From: Cong Wang
Date: Sun Jun 27 2021 - 14:29:36 EST


On Fri, Jun 25, 2021 at 1:23 PM Pavel Skripkin <paskripkin@xxxxxxxxx> wrote:
>
> Syzbot reported warning in tcindex_alloc_perfect_hash. The problem
> was in too big cp->hash, which triggers warning in kmalloc. Since
> cp->hash comes from userspace, there is no need to warn if value
> is not correct
>
> Fixes: b9a24bb76bf6 ("net_sched: properly handle failure case of tcf_exts_init()")
> Reported-and-tested-by: syzbot+1071ad60cd7df39fdadb@xxxxxxxxxxxxxxxxxxxxxxxxx
> Signed-off-by: Pavel Skripkin <paskripkin@xxxxxxxxx>

Looks reasonable.

Acked-by: Cong Wang <cong.wang@xxxxxxxxxxxxx>

Thanks.