Re: [PATCH v2 1/4] mm: pagewalk: Fix walk for hugepage tables

From: Michael Ellerman
Date: Fri Jun 25 2021 - 19:46:55 EST


Christophe Leroy <christophe.leroy@xxxxxxxxxx> writes:
> Le 25/06/2021 à 06:45, Michael Ellerman a écrit :
>> Christophe Leroy <christophe.leroy@xxxxxxxxxx> writes:
>>> Hi Michael,
>>>
>>> Le 19/04/2021 à 12:47, Christophe Leroy a écrit :
>>>> Pagewalk ignores hugepd entries and walk down the tables
>>>> as if it was traditionnal entries, leading to crazy result.
>>>>
>>>> Add walk_hugepd_range() and use it to walk hugepage tables.
>>>
>>> I see you took patch 2 and 3 of the series.
>>
>> Yeah I decided those were bug fixes so could be taken separately.
>>
>>> Do you expect Andrew to take patch 1 via mm tree, and then you'll take
>>> patch 4 once mm tree is merged ?
>>
>> I didn't feel I could take patch 1 via the powerpc tree without risking
>> conflicts.
>>
>> Andrew could take patch 1 and 4 via mm, though he might not want to pick
>> them up this late.
>
> Patch 4 needs patches 2 and 3 and doesn't apply without them so it is not that easy.

Ah duh, sorry.

> Maybe Andrew you can take patch 1 now and then Michael you can take patch 4 at anytime during 5.15
> preparation without any conflict risk ?

Yeah that would work.

>> I guess step one would be to repost 1 and 4 as a new series. Either they
>> can go via mm, or for 5.15 I could probably take them both as long as I
>> pick them up early enough.
>>
>
> I'll first repost patch 1 as standalone and see what happens.

Thanks.

cheers