Re: [PATCH] certs: Redirect openssl error message to null device

[Stefan Berger]

On 6/25/21 8:29 AM, Stefan Berger wrote:

> From: Stefan Berger <stefanb@xxxxxxxxxxxxx>
>
> Address the following issue detected by the kernel test robot when
> there's no certificate file at the time when checking for the type
> of key in the cert:
>
> Can't open certs/signing_key.pem for reading, No such file or directory
>
> The simplest solution is to redirect openssl's stderr output to /dev/null.
>
> Fixes: 28d62d945ded ("certs: Trigger creation of RSA module signing key if it's not an RSA key")
> Signed-off-by: Stefan Berger <stefanb@xxxxxxxxxxxxx>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>


Jarkko,

can you please squash this patch into the one it fixes. Unfortunately 
when rebasing you will have to fix the subsequent patch from this merge 
error

ifeq ($(openssl_available),yes)
<<<<<<< HEAD
X509TEXT=$(shell openssl x509 -in $(CONFIG_MODULE_SIG_KEY) -text 
2>/dev/null)
=======
X509TEXT=$(shell openssl x509 -in $(CONFIG_MODULE_SIG_KEY) -text)
endif
>>>>>>> 87e968848116 (certs: Add support for using elliptic curve keys 
for signing modules)

to this:


ifeq ($(openssl_available),yes)
X509TEXT=$(shell openssl x509 -in $(CONFIG_MODULE_SIG_KEY) -text 
2>/dev/null)
endif

Thanks.

   Stefan