Re: [PATCH] pinctrl: bcm2835: Replace BUG with BUG_ON

From: Florian Fainelli
Date: Thu Jun 24 2021 - 12:22:48 EST


On 6/23/21 11:49 PM, Jason Wang wrote:
> The if condition followed by BUG can be replaced to BUG_ON which is
> more compact and formal in linux source.
>
> Signed-off-by: Jason Wang <wangborong@xxxxxxxxxx>

Acked-by: Florian Fainelli <f.fainelli@xxxxxxxxx>

Although I would rather completely remove this BUG_ON() and replace it
with a WARN_ON() instead, no need to kill the machine for such a
problem, however unlikely it is to appear.
--
Florian