Re: [PATCH v2] tty: n_gsm: CR bit value should be 0 when config "initiator=0"

From: Greg KH
Date: Thu Jun 24 2021 - 08:58:20 EST


On Wed, Jun 16, 2021 at 07:53:22PM +0800, Zhenguo Zhao wrote:
> From: Zhenguo Zhao <zhenguo.zhao1@xxxxxxxxxx>
>
> config "initiator=0",gsmld will receives dlci SABM/DISC control command
> frame,as slaver,the CR bit value check should be 1.

I am really sorry, but I do not understand this changelog comment. Can
you try rewriting it again?

>
> if check "cr == 0",it will goto invalid,so it can't send UA response
> frame and open slaver dlci.

Same here, I do not understand.

thanks,

greg k-h