Re: [PATCH] drm/bridge: dw-mipi-dsi: Move drm_bridge_add into probe

From: Jagan Teki
Date: Thu Jun 24 2021 - 08:34:52 EST


Hi Jonathan,

On Fri, Jun 18, 2021 at 6:40 PM Jonathan Liu <net147@xxxxxxxxx> wrote:
>
> Hi Jagan,
>
> On Wed, 3 Feb 2021 at 09:13, Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx> wrote:
> > @@ -1167,6 +1151,20 @@ __dw_mipi_dsi_probe(struct platform_device *pdev,
> > dw_mipi_dsi_debugfs_init(dsi);
> > pm_runtime_enable(dev);
> >
> > + ret = drm_of_find_panel_or_bridge(dev->of_node, 1, 0,
> > + &panel, &bridge);
> > + if (ret)
> > + return ERR_PTR(ret);
>
> On RK3399 if the error is EPROBE_DEFER, __dw_mipi_dsi_probe can be
> called again and result in the following errors:
> [ 0.717589] debugfs: Directory 'ff960000.mipi' with parent '/'
> already present!
> [ 0.717601] dw-mipi-dsi-rockchip ff960000.mipi: failed to create debugfs root
> [ 0.717606] dw-mipi-dsi-rockchip ff960000.mipi: Unbalanced pm_runtime_enable!

Is this when you test bridge on rk3399 or panel?

Jagan.