Re: [PATCH v3] block: fix trace completion for chained bio

From: Christoph Hellwig
Date: Thu Jun 24 2021 - 03:02:36 EST


On Thu, Jun 24, 2021 at 02:50:30PM +0800, Edward Hsieh wrote:
> We are suggested by Neil Brown in the last version that from the
> comment, the bio_chain_endio handling is used *only* to avoid
> deep recursion so it should be at the end of the function.
> Therefore, the position of blk_throtl_bio_endio() and bio_uninit()
> are a bit odd.

This is BS. Placement of an else after a returning statement does
not change code generation.

> If it's not necessary then V2 patch should work to fix the
> missing completion traces. Should we resend PATCH V2?

Please send an updated version.