Re: [PATCH rdma-next v2] RDMA: Fix kernel-doc warnings about wrong comment
From: Jason Gunthorpe
Date: Mon Jun 21 2021 - 19:52:40 EST
On Wed, Jun 16, 2021 at 09:09:47AM +0300, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@xxxxxxxxxx>
>
> Compilation with W=1 produces warnings similar to the below.
>
> drivers/infiniband/ulp/ipoib/ipoib_main.c:320: warning: This comment
> starts with '/**', but isn't a kernel-doc comment. Refer
> Documentation/doc-guide/kernel-doc.rst
>
> All such occurrences were found with the following one line
> git grep -A 1 "\/\*\*" drivers/infiniband/
>
> Reviewed-by: Jack Wang <jinpu.wang@xxxxxxxxx> #rtrs
> Reviewed-by: Dennis Dalessandro <dennis.dalessandro@xxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxx>
> ---
> Changelog:
> v1 https://lore.kernel.org/lkml/8b40bbff098247962af5a7b35d47b2e964daa523.1622726066.git.leonro@xxxxxxxxxx
> * Found two extra places in hns_roce_hem.c
> * Added Dennis's ROB
> v0 https://lore.kernel.org/lkml/635def71048cbffe76e2dd324cf420d8a465ee9d.1622460676.git.leonro@xxxxxxxxxx:
> * Rebased to drop i40iw
> * Added Jack's ROB
> ---
> drivers/infiniband/core/iwpm_util.h | 2 +-
> drivers/infiniband/core/roce_gid_mgmt.c | 5 +++--
> drivers/infiniband/hw/hfi1/chip.c | 4 ++--
> drivers/infiniband/hw/hfi1/file_ops.c | 6 +++---
> drivers/infiniband/hw/hfi1/hfi.h | 2 +-
> drivers/infiniband/hw/hfi1/init.c | 4 ++--
> drivers/infiniband/hw/hfi1/pio.c | 2 +-
> drivers/infiniband/hw/hns/hns_roce_hem.c | 4 ++--
> drivers/infiniband/sw/rdmavt/mr.c | 4 ++--
> drivers/infiniband/sw/rdmavt/qp.c | 3 ++-
> drivers/infiniband/sw/rdmavt/vt.c | 4 ++--
> drivers/infiniband/ulp/ipoib/ipoib_main.c | 7 ++++---
> drivers/infiniband/ulp/iser/iser_verbs.c | 2 +-
> drivers/infiniband/ulp/isert/ib_isert.c | 4 ++--
> drivers/infiniband/ulp/rtrs/rtrs-clt.c | 4 ++--
> drivers/infiniband/ulp/rtrs/rtrs-srv.c | 2 +-
> 16 files changed, 31 insertions(+), 28 deletions(-)
Applied to for-next, thanks
Jason