Re: [RFC] schedutil: Fix iowait boost issues for slow I/O devices

From: Joel Fernandes
Date: Fri Jun 18 2021 - 20:33:52 EST


On Fri, Jun 18, 2021 at 4:34 AM Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
>
>
> Aside from everything else:
>
> On Fri, Jun 18, 2021 at 12:06:39AM -0400, Joel Fernandes (Google) wrote:
>
> > +unsigned int sysctl_iowait_reset_ticks = 20;
> > +unsigned int sysctl_iowait_apply_ticks = 10;
>
> Never expose HZ to userspace. we even have USER_HZ (no new usage please)
> that fixed existing problems with that.
>
> If you expose a knob, make it in sane time units and convert internally
> to whatever you need. That said; less is more with knobs.

Sorry, you are right and good idea. I will look into making such a
modification while I wait for comments from others as well on rest of
the patch.

thanks,

-Joel