Re: [PATCH v3 03/11] x86/cpufeatures: Add TDX Guest CPU feature

From: Kuppuswamy, Sathyanarayanan
Date: Fri Jun 18 2021 - 20:13:47 EST




On 6/18/21 4:39 PM, Borislav Petkov wrote:
From Documentation/process/submitting-patches.rst:

"Both Tested-by and Reviewed-by tags, once received on mailing list from tester
or reviewer, should be added by author to the applicable patches when sending
next versions. However if the patch has changed substantially in following
version, these tags might not be applicable anymore and thus should be removed.
Usually removal of someone's Tested-by or Reviewed-by tags should be mentioned
in the patch changelog (after the '---' separator)."

IOW, for the next revisions of your patchsets, you should drop
Reviewed-by: tags on patches when they've changed more than trivially
because otherwise those tags have no meaning at all.

Also, please take the time to peruse the above document on the kernel
process while waiting.

I will make sure to remove the Reviewed-by/Tested-by tags for the changed patches
in the next submission. But, IMO, changes made in this patch is minimal. Nothing
changed functionally. So, do we still need to remove the tags for this patch?

--
Sathyanarayanan Kuppuswamy
Linux Kernel Developer