Re: [PATCH net-next] net/sched: cls_flower: fix resetting of ether proto mask

From: Vladimir Oltean
Date: Thu Jun 17 2021 - 12:42:03 EST


On Thu, Jun 17, 2021 at 07:14:35PM +0300, Vadym Kochan wrote:
> In case of matching 'protocol' the rule does not work:
>
> tc filter add dev $DEV ingress prio 1 protocol $PROTO flower skip_sw action drop
>
> so clear the ether proto mask only for CVLAN case.
>
> The issue was observed by testing on Marvell Prestera Switchdev driver
> with recent 'flower' offloading feature.
>
> Fixes: 0dca2c7404a9 ("net/sched: cls_flower: Remove match on n_proto")
> CC: Boris Sukholitko <boris.sukholitko@xxxxxxxxxxxx>
> Signed-off-by: Vadym Kochan <vadym.kochan@xxxxxxxxxxx>
> ---

You resent the patch very quickly, did you find out why Boris' patch was
working in the first place?