Re: [PATCH] be2net: Fix an error handling path in 'be_probe()'

[Somnath Kotur]

On Thu, Jun 17, 2021 at 12:13 AM Christophe JAILLET
<christophe.jaillet@xxxxxxxxxx> wrote:
>
> If an error occurs after a 'pci_enable_pcie_error_reporting()' call, it
> must be undone by a corresponding 'pci_disable_pcie_error_reporting()'
> call, as already done in the remove function.
>
> Fixes: d6b6d9877878 ("be2net: use PCIe AER capability")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> ---
>  drivers/net/ethernet/emulex/benet/be_main.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c
> index b6eba29d8e99..7968568bbe21 100644
> --- a/drivers/net/ethernet/emulex/benet/be_main.c
> +++ b/drivers/net/ethernet/emulex/benet/be_main.c
> @@ -5897,6 +5897,7 @@ static int be_probe(struct pci_dev *pdev, const struct pci_device_id *pdev_id)
>  unmap_bars:
>         be_unmap_pci_bars(adapter);
>  free_netdev:
> +       pci_disable_pcie_error_reporting(pdev);
>         free_netdev(netdev);
>  rel_reg:
>         pci_release_regions(pdev);
> --
> 2.30.2
>
Acked-by: Somnath Kotur <somnath.kotur@xxxxxxxxxxxx>

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature