Re: [PATCH] x86/sgx: Add missing xa_destroy() when virtual EPC is destroyed

From: Dave Hansen
Date: Tue Jun 15 2021 - 11:39:47 EST


On 6/15/21 3:16 AM, Kai Huang wrote:
> xa_destroy() needs to be called to destroy virtual EPC's page arra
> before calling kfree() to free the virtual EPC. Currently it is not
> calaled. Add the missing xa_destroy() to fix.

Looks good Kai, thanks for fixing this.

Could you please take a good look through the sgx_release() and the vpec
equivalent and see if anything else stands out as possibly being missed?
Also, is this the kind of thing that a simple open/add/close selftest
might have found?

Maybe we should beef up the selftests a bit.

Acked-by: Dave Hansen <dave.hansen@xxxxxxxxx>