Re: [net-next: PATCH 1/3] net: mvmdio: add ACPI support

From: Marcin Wojtas
Date: Tue Jun 15 2021 - 11:13:42 EST


Hi,

niedz., 13 cze 2021 o 21:20 Andrew Lunn <andrew@xxxxxxx> napisał(a):
>
> > - ret = of_mdiobus_register(bus, pdev->dev.of_node);
> > + if (pdev->dev.of_node)
> > + ret = of_mdiobus_register(bus, pdev->dev.of_node);
> > + else if (is_acpi_node(pdev->dev.fwnode))
> > + ret = acpi_mdiobus_register(bus, pdev->dev.fwnode);
> > + else
> > + ret = -EINVAL;
>
>
> This seems like something which could be put into fwnode_mdio.c.
>

Agree - I'll create a simple fwnode_mdiobus_register() helper there.

Best regards,
Marcin