Re: [PATCH] KVM: arm64: Trival coding style fixes for all vgic-related files

From: Marc Zyngier
Date: Tue Jun 15 2021 - 05:48:35 EST


On Tue, 15 Jun 2021 04:50:19 +0100,
Yanan Wang <wangyanan55@xxxxxxxxxx> wrote:
>
> These fixes introduce no functional change but just adjustment about
> coding style issues for ARM64 vgic code. They mainly include identation
> fix of function parameters/arguments, identation fix of structure
> initialization, identation fix of comment, also the deletion of some
> superfluous space lines.

Please don't. This sort of patches bring little value, and make the
backporting of important fixes more difficult because of pointless
context change.

Fixing these cosmetic details is fine when you are modifying the
code. But as a standalone patch, this brings more pain than benefit.

Thanks,

M.

--
Without deviation from the norm, progress is not possible.