Re: [PATCH] mm: memcontrol: Remove trailing semicolon in macros

[Shakeel Butt]

+lkml and linux-mm

On Mon, Jun 14, 2021 at 2:15 AM Huilong Deng <denghuilong@xxxxxxxxxx> wrote:
>
> Macros should not use a trailing semicolon.
>
> Signed-off-by: Huilong Deng <denghuilong@xxxxxxxxxx>

Reviewed-by: Shakeel Butt <shakeelb@xxxxxxxxxx>

> ---
>  include/linux/memcontrol.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h
> index 3cc18c2176e7..1c1b11530ab6 100644
> --- a/include/linux/memcontrol.h
> +++ b/include/linux/memcontrol.h
> @@ -192,7 +192,7 @@ enum memcg_kmem_state {
>  struct memcg_padding {
>         char x[0];
>  } ____cacheline_internodealigned_in_smp;
> -#define MEMCG_PADDING(name)      struct memcg_padding name;
> +#define MEMCG_PADDING(name)      struct memcg_padding name
>  #else
>  #define MEMCG_PADDING(name)
>  #endif
> --
> 2.31.1
>
>
>