Re: [PATCH 09/11] PCI: add matching checks for driver_override binding

From: Jason Gunthorpe
Date: Mon Jun 14 2021 - 12:33:43 EST


On Mon, Jun 14, 2021 at 05:15:22PM +0100, Christoph Hellwig wrote:
> On Mon, Jun 14, 2021 at 01:01:25PM -0300, Jason Gunthorpe wrote:
> > > Isn't struct pci_device_id a userspace ABI due to MODULE_DEVICE_TABLE()?
> >
> > Not that I can find, it isn't under include/uapi and the way to find
> > this information is by looking for symbols starting with "__mod_"
> >
> > Debian Code Search says the only place with '"__mod_"' is in
> > file2alias.c at least
> >
> > Do you know of something? If yes this file should be moved
>
> Seems lke file2alias.c is indeed the only consumer. So it is a
> userspace ABI, but ony to a file included in the kernel tree.

As I understand it, things are tighter than that, it is only an API
between different parts of kbuild - so it is OK to change
it. module.alias is the uAPI this data gets marshaled into.

Jason