Re: [PATCH 09/11] PCI: add matching checks for driver_override binding

From: Jason Gunthorpe
Date: Mon Jun 14 2021 - 12:01:32 EST


On Mon, Jun 14, 2021 at 04:27:33PM +0100, Christoph Hellwig wrote:
> On Mon, Jun 14, 2021 at 11:18:32AM +0300, Max Gurtovoy wrote:
> > * into a static list of equivalent device types,
> > * instead of using it as a pointer.
> > + * @flags: PCI flags of the driver. Bitmap of pci_id_flags enum.
> > */
> > struct pci_device_id {
> > __u32 vendor, device; /* Vendor and device ID or PCI_ANY_ID*/
> > __u32 subvendor, subdevice; /* Subsystem ID's or PCI_ANY_ID */
> > __u32 class, class_mask; /* (class,subclass,prog-if) triplet */
> > kernel_ulong_t driver_data; /* Data private to the driver */
> > + __u32 flags;
> > };
>
> Isn't struct pci_device_id a userspace ABI due to MODULE_DEVICE_TABLE()?

Not that I can find, it isn't under include/uapi and the way to find
this information is by looking for symbols starting with "__mod_"

Debian Code Search says the only place with '"__mod_"' is in
file2alias.c at least

Do you know of something? If yes this file should be moved

Jason