Re: [PATCH 3/3] mm: require ->set_page_dirty to be explicitly wire up

From: Christoph Hellwig
Date: Mon Jun 14 2021 - 06:03:40 EST


On Mon, Jun 14, 2021 at 11:51:07AM +0200, Jan Kara wrote:
> On Mon 14-06-21 08:15:12, Christoph Hellwig wrote:
> > Remove the CONFIG_BLOCK default to __set_page_dirty_buffers and just
> > wire that method up for the missing instances.
> >
> > Signed-off-by: Christoph Hellwig <hch@xxxxxx>
>
> Make sense. Did you somehow autogenerate this? If this patch would race
> with addition of new aops struct, we'd get null-ptr-defer out of that so
> maybe providing the script would be better. But other than that the changes
> look good to me. You can add:

No, this was done manually as I audited all instances for actually being
able to dirty pages.