Re: [PATCH 0/6] staging: rtl8188eu: remove hal/odm_debug.h

From: Phillip Potter
Date: Sat Jun 12 2021 - 13:40:53 EST


On Fri, Jun 11, 2021 at 05:35:50PM +0200, Martin Kaiser wrote:
> Thus wrote Dan Carpenter (dan.carpenter@xxxxxxxxxx):
>
> > On Fri, Jun 11, 2021 at 01:24:58AM +0100, Phillip Potter wrote:
> > > This series removes hal/odm_debug.h, which contains various preprocessor
> > > definitions, as well as an unwieldy ODM_RT_TRACE macro which is not best
> > > practice. It also removes all uses of this macro, and the associated
> > > fields in struct odm_dm_struct which are only used by this macro.
>
> > > This makes the code cleaner, thus moving it closer to getting out of
> > > staging.
>
> > Looks good.
>
> > Reviewed-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>
> same here: looks ok and doesn't break anything
>
> Reviewed-by: Martin Kaiser <martin@xxxxxxxxx>
> Tested-by: Martin Kaiser <martin@xxxxxxxxx>
>
> Best regards,
>
> Martin

Dear Martin,

Thank you for reviewing and testing.

Regards,
Phil