Re: [PATCH v2 2/5] ARM: dts: NSP: Add Meraki MX64/MX65 to Makefile

From: Matthew Hagan
Date: Sat Jun 12 2021 - 05:23:26 EST



On 11/06/2021 21:24, Vladimir Oltean wrote:
> On Fri, Jun 11, 2021 at 12:27:14AM +0100, Matthew Hagan wrote:
>> Add Makefile entries for the Meraki MX64/MX65 series devices.
>>
>> Signed-off-by: Matthew Hagan <mnhagan88@xxxxxxxxx>
>> ---
>> arch/arm/boot/dts/Makefile | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>> index f8f09c5066e7..033d9604db60 100644
>> --- a/arch/arm/boot/dts/Makefile
>> +++ b/arch/arm/boot/dts/Makefile
>> @@ -154,6 +154,12 @@ dtb-$(CONFIG_ARCH_BCM_NSP) += \
>> bcm958525xmc.dtb \
>> bcm958622hr.dtb \
>> bcm958623hr.dtb \
>> + bcm958625-meraki-mx64.dtb \
>> + bcm958625-meraki-mx64-a0.dtb \
>> + bcm958625-meraki-mx64w.dtb \
>> + bcm958625-meraki-mx64w-a0.dtb \
>> + bcm958625-meraki-mx65.dtb \
>> + bcm958625-meraki-mx65w.dtb \
>> bcm958625hr.dtb \
>> bcm988312hr.dtb \
>> bcm958625k.dtb
>> --
>> 2.26.3
>>
> It is odd to add the device trees to the Makefile in a separate patch
> compared to their actual introduction. Does the tree even compile at
> this stage?

Will rectify this. Thanks!