Re: [PATCH] counter: interrupt-cnt: Add const qualifier for actions_list array

From: Jonathan Cameron
Date: Fri Jun 11 2021 - 14:00:43 EST


On Thu, 10 Jun 2021 05:23:47 +0200
Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx> wrote:

> Hi William,
>
> On Thu, Jun 10, 2021 at 10:36:42AM +0900, William Breathitt Gray wrote:
> > The struct counter_synapse actions_list member expects a const enum
> > counter_synapse_action array. This patch renames
> > interrupt_cnt_synapse_actionss to interrupt_cnt_synapse_actions and adds
> > a const qualifier to match actions_list.
> >
> > Cc: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>
> > Signed-off-by: William Breathitt Gray <vilhelm.gray@xxxxxxxxx>
>
> Reviewed-by: <o.rempel@xxxxxxxxxxxxxx>
Applied to the togreg branch of iio.git and pushed out as testing for 0-day
to see if it can find anything we missed.

Thanks,

Jonathan

>
> thank you!
>
> > ---
> > drivers/counter/interrupt-cnt.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/counter/interrupt-cnt.c b/drivers/counter/interrupt-cnt.c
> > index 827d785e19b4..5df7cd13d4c7 100644
> > --- a/drivers/counter/interrupt-cnt.c
> > +++ b/drivers/counter/interrupt-cnt.c
> > @@ -77,7 +77,7 @@ static const struct counter_count_ext interrupt_cnt_ext[] = {
> > },
> > };
> >
> > -static enum counter_synapse_action interrupt_cnt_synapse_actionss[] = {
> > +static const enum counter_synapse_action interrupt_cnt_synapse_actions[] = {
> > COUNTER_SYNAPSE_ACTION_RISING_EDGE,
> > };
> >
> > @@ -194,8 +194,8 @@ static int interrupt_cnt_probe(struct platform_device *pdev)
> > priv->counter.signals = &priv->signals;
> > priv->counter.num_signals = 1;
> >
> > - priv->synapses.actions_list = interrupt_cnt_synapse_actionss;
> > - priv->synapses.num_actions = ARRAY_SIZE(interrupt_cnt_synapse_actionss);
> > + priv->synapses.actions_list = interrupt_cnt_synapse_actions;
> > + priv->synapses.num_actions = ARRAY_SIZE(interrupt_cnt_synapse_actions);
> > priv->synapses.signal = &priv->signals;
> >
> > priv->cnts.name = "Channel 0 Count";
> > --
> > 2.32.0
> >
> >
> >
>