Re: [PATCH 5.13] mwifiex: bring down link before deleting interface

From: Kalle Valo
Date: Fri Jun 11 2021 - 05:53:46 EST


Brian Norris <briannorris@xxxxxxxxxxxx> writes:

> On Fri, May 14, 2021 at 7:45 PM Brian Norris <briannorris@xxxxxxxxxxxx> wrote:
>>
>> We can deadlock when rmmod'ing the driver or going through firmware
>> reset, because the cfg80211_unregister_wdev() has to bring down the link
>> for us, ... which then grab the same wiphy lock.
> ...
>> Fixes: a05829a7222e ("cfg80211: avoid holding the RTNL when calling the driver")
>> Cc: stable@xxxxxxxxxxxxxxx
>> Link:
>> https://lore.kernel.org/linux-wireless/98392296-40ee-6300-369c-32e16cff3725@xxxxxxxxx/
>> Link:
>> https://lore.kernel.org/linux-wireless/ab4d00ce52f32bd8e45ad0448a44737e@xxxxxxxxx/
>> Reported-by: Maximilian Luz <luzmaximilian@xxxxxxxxx>
>> Reported-by: dave@xxxxxxxxx
>> Cc: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
>> Signed-off-by: Brian Norris <briannorris@xxxxxxxxxxxx>
>
> Ping - is this going to get merged? It's a 5.12 regression, and we
> have multiple people complaining about it (and they tested the fix
> too!).

Thanks for the ping, this got piled up under all the -next patches and I
missed it. I'll look at it now.

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches