Re: [PATCH v2 2/7] sched: Introduce task_is_running()

From: Geert Uytterhoeven
Date: Fri Jun 11 2021 - 04:50:11 EST


Hoi Peter,

Thanks for your patch!

On Fri, Jun 11, 2021 at 10:36 AM Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
> Replace a bunch of 'p->state == TASK_RUNNING' with a new helper:
> task_is_running(p).

You're also sticking a READ_ONCE() in the helper, which wasn't done
by any of the old implementations? Care to mention why?

> Signed-off-by: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>
> Acked-by: Davidlohr Bueso <dave@xxxxxxxxxxxx>

> arch/m68k/kernel/process.c | 2 +-

Regardless:
Acked-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds