Re: [PATCH] arm64: dts: meson: vim3: reduce cpu thermal fan trigger temperature

[Neil Armstrong]

Hi,

On 11/06/2021 08:54, Nick Xie wrote:
> Hello Neil,
> 
> The MCU FAN won't work until the temperature reach to 80 degree centigrade,
> Do you think the temperature is too high?

I think 80 is tool high, but I fear 50 is way too low, but if you think 50 is OK after you ran some tests, just add it to the commit log and it's ok for me.

Neil

> 
> Thanks.
> 
> Neil Armstrong <narmstrong@xxxxxxxxxxxx <mailto:narmstrong@xxxxxxxxxxxx>> 于2021年6月11日周五 下午2:44写道：
> 
>     Hi Nick,
> 
>     On 09/06/2021 03:28, xieqinick@xxxxxxxxx <mailto:xieqinick@xxxxxxxxx> wrote:
>     > From: Nick Xie <nick@xxxxxxxxxx <mailto:nick@xxxxxxxxxx>>
>     >
>     > Reduce the MCU FAN trigger temperature from
>     > 80 degree centigrade to 50 degree centigrade.
> 
>     Can you add some more rationale to this change ?
> 
>     >
>     > Signed-off-by: Nick Xie <nick@xxxxxxxxxx <mailto:nick@xxxxxxxxxx>>
>     > ---
>     >  arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi | 2 +-
>     >  1 file changed, 1 insertion(+), 1 deletion(-)
>     >
>     > diff --git a/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi b/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi
>     > index 66d67524b031..a9c34fee91f4 100644
>     > --- a/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi
>     > +++ b/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi
>     > @@ -256,7 +256,7 @@ &cecb_AO {
>     >  &cpu_thermal {
>     >       trips {
>     >               cpu_active: cpu-active {
>     > -                     temperature = <80000>; /* millicelsius */
>     > +                     temperature = <50000>; /* millicelsius */
>     >                       hysteresis = <2000>; /* millicelsius */
>     >                       type = "active";
>     >               };
>     >
> 
>     With that:
>     Reviewed-by: Neil Armstrong <narmstrong@xxxxxxxxxxxx <mailto:narmstrong@xxxxxxxxxxxx>>
>