RE: [PATCH][next] cifsd: fix kfree of uninitialized pointer oid

From: Namjae Jeon
Date: Thu Jun 10 2021 - 20:40:32 EST


> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> Currently function ksmbd_neg_token_init_mech_type can kfree an uninitialized pointer oid when the call
> to asn1_oid_decode fails when vlen is out of range. All the other failure cases in function
> asn1_oid_decode set *oid to NULL on an error, so fix the issue by ensuring the vlen out of range error
> also nullifies the pointer.
>
> Fixes: 8bae4419ce63 ("cifsd: add goto fail in neg_token_init_mech_type()")
> Addresses-Coverity: ("Uninitialized pointer read")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
I will apply, Thanks for your patch!