Re: [PATCH 1/2] ima: Fix warning: no previous prototype for function 'ima_add_kexec_buffer'

From: Rob Herring
Date: Thu Jun 10 2021 - 13:34:35 EST


On Thu, Jun 10, 2021 at 12:16 PM Lakshmi Ramasubramanian
<nramas@xxxxxxxxxxxxxxxxxxx> wrote:
>
> The function prototype for ima_add_kexec_buffer() is present
> in 'linux/ima.h'. But this header file is not included in
> ima_kexec.c where the function is implemented. This results
> in the following compiler warning when "-Wmissing-prototypes" flag
> is turned on:
>
> security/integrity/ima/ima_kexec.c:81:6: warning: no previous prototype
> for function 'ima_add_kexec_buffer' [-Wmissing-prototypes]
>
> Include the header file 'linux/ima.h' in ima_kexec.c to fix
> the compiler warning.
>
> Fixes: dce92f6b11c3 (arm64: Enable passing IMA log to next kernel on kexec)
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Signed-off-by: Lakshmi Ramasubramanian <nramas@xxxxxxxxxxxxxxxxxxx>
> ---
> security/integrity/ima/ima_kexec.c | 1 +
> 1 file changed, 1 insertion(+)

Acked-by: Rob Herring <robh@xxxxxxxxxx>