Re: [PATCH 06/11] mm: page_vma_mapped_walk(): crossing page table boundary

From: Kirill A. Shutemov
Date: Thu Jun 10 2021 - 05:32:08 EST


On Wed, Jun 09, 2021 at 11:44:10PM -0700, Hugh Dickins wrote:
> page_vma_mapped_walk() cleanup: adjust the test for crossing page table
> boundary - I believe pvmw->address is always page-aligned, but nothing
> else here assumed that;

Maybe we should just get it aligned instead? (PMD_SIZE - PAGE_SIZE) is not
most obvious mask calculation.

> and remember to reset pvmw->pte to NULL after
> unmapping the page table, though I never saw any bug from that.

Okay, it's fair enough.

--
Kirill A. Shutemov