[tip: perf/urgent] irq_work: Make irq_work_queue() NMI-safe again

From: tip-bot2 for Peter Zijlstra
Date: Thu Jun 10 2021 - 04:13:23 EST


The following commit has been merged into the perf/urgent branch of tip:

Commit-ID: 156172a13ff0626d8e23276e741c7e2cb2f3b572
Gitweb: https://git.kernel.org/tip/156172a13ff0626d8e23276e741c7e2cb2f3b572
Author: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
AuthorDate: Tue, 08 Jun 2021 19:54:15 +02:00
Committer: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
CommitterDate: Thu, 10 Jun 2021 10:00:08 +02:00

irq_work: Make irq_work_queue() NMI-safe again

Someone carelessly put NMI unsafe code in irq_work_queue(), breaking
just about every single user. Also, someone has a terrible comment
style.

Fixes: e2b5bcf9f5ba ("irq_work: record irq_work_queue() call stack")
Reported-by: Alexander Shishkin <alexander.shishkin@xxxxxxxxxxxxxxx>
Signed-off-by: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>
Link: https://lkml.kernel.org/r/YL+uBq8LzXXZsYVf@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
---
kernel/irq_work.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/kernel/irq_work.c b/kernel/irq_work.c
index 23a7a0b..db8c248 100644
--- a/kernel/irq_work.c
+++ b/kernel/irq_work.c
@@ -70,9 +70,6 @@ bool irq_work_queue(struct irq_work *work)
if (!irq_work_claim(work))
return false;

- /*record irq_work call stack in order to print it in KASAN reports*/
- kasan_record_aux_stack(work);
-
/* Queue the entry and raise the IPI if needed. */
preempt_disable();
__irq_work_queue_local(work);