Re: [PATCH][next] ACPI: scan: ensure ret is initialized to avoid garbage being returned

[Dan Carpenter]

On Wed, Jun 09, 2021 at 10:38:04PM +0100, Daniel Scally wrote:
> Hi Colin
> 
> On Wed, Jun 9, 2021 at 6:33 PM Colin King <colin.king@xxxxxxxxxxxxx> wrote:
> >
> > From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> >
> > In the unlikely event that there are no callback calls made then ret
> > will be returned as an uninitialized value. Clean up static analysis
> > warnings by ensuring ret is initialized.
> 
> Ah, thanks - good spot.
> 
> > Addresses-Coverity: ("Uninitialized scalar variable")
> > Fixes: a9e10e587304 ("ACPI: scan: Extend acpi_walk_dep_device_list()")
> > Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> 
> Reviewed-by: Daniel Scally <djrscally@xxxxxxxxx>
> 
> I'm still bad at Git; will the commit hash here be right, since the
> patch that this fixes isn't upstream yet?

The hash is stable unless the branch rebases.  When maintainers rebase a
branch, they're expected to update the Fixes tags as well.  Most people
probably have a script to do it.  I think Stephen Rothwell has a script
which checks whether Fixes tags are correct?

regards,
dan carpenter