Re: [PATCH v36 4/4] scsi: ufs: Add HPB 2.0 support

From: Greg KH
Date: Thu Jun 10 2021 - 02:07:39 EST


On Wed, Jun 09, 2021 at 08:37:49PM -0700, Bart Van Assche wrote:
> On 6/6/21 9:19 PM, Daejun Park wrote:
> > -What: /sys/class/scsi_device/*/device/hpb_sysfs/hit_cnt
> > +What: /sys/class/scsi_device/*/device/hpb_stat_sysfs/hit_cnt
> > Date: June 2021
> > Contact: Daejun Park <daejun7.park@xxxxxxxxxxx>
> > Description: This entry shows the number of reads that changed to HPB read.
> >
> > The file is read only.
>
> Is it really useful to have a suffix "_sysfs" for a directory that
> occurs in sysfs? If not, please leave it out.

Ugh, missed that, yes it should be dropped, that's pointless :)

thanks,

greg k-h