Re: [RFC v2-fix-v2 1/1] x86: Introduce generic protected guest abstraction

From: Borislav Petkov
Date: Wed Jun 09 2021 - 11:02:09 EST


On Wed, Jun 09, 2021 at 07:56:14AM -0700, Kuppuswamy, Sathyanarayanan wrote:
> And any arch which wants to support prot_guest_has() can enable above
> config option and create their own asm/protected_guest.

I wouldnt've done even that but only the x86 asm version of
protected_guest.h and left it to other arches to extend it. I don't
like "preempting" use of functionality by other arches and would
leave them to extend stuff themselves, as they see fit, but ok,
ARCH_HAS_PROTECTED_GUEST sounds clean enough to me too, so sure, that's
fine too.

Thx.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette