Re: [PATCH 6/7] fpga: xilinx: remove xilinx- prefix on files

[Tom Rix]

On 6/9/21 2:59 AM, Greg KH wrote:
> On Tue, Jun 08, 2021 at 09:25:51AM -0700, trix@xxxxxxxxxx wrote:
> > From: Tom Rix <trix@xxxxxxxxxx>
> >
> > It is not necessary to have a xilinx- prefix on a file
> > when the file is in a xilinx/ subdir.
> >
> > Signed-off-by: Tom Rix <trix@xxxxxxxxxx>
> > ---
> >   drivers/fpga/xilinx/Makefile                                  | 4 ++--
> >   drivers/fpga/xilinx/{xilinx-pr-decoupler.c => pr-decoupler.c} | 0
> >   drivers/fpga/xilinx/{xilinx-spi.c => spi.c}                   | 0
> >   3 files changed, 2 insertions(+), 2 deletions(-)
> >   rename drivers/fpga/xilinx/{xilinx-pr-decoupler.c => pr-decoupler.c} (100%)
> >   rename drivers/fpga/xilinx/{xilinx-spi.c => spi.c} (100%)
> >
> > diff --git a/drivers/fpga/xilinx/Makefile b/drivers/fpga/xilinx/Makefile
> > index 7bb7543412790..4ac727d03e140 100644
> > --- a/drivers/fpga/xilinx/Makefile
> > +++ b/drivers/fpga/xilinx/Makefile
> > @@ -1,7 +1,7 @@
> >   # SPDX-License-Identifier: GPL-2.0
> >   
> > -obj-$(CONFIG_XILINX_PR_DECOUPLER) += xilinx-pr-decoupler.o
> > -obj-$(CONFIG_FPGA_MGR_XILINX_SPI) += xilinx-spi.o
> > +obj-$(CONFIG_XILINX_PR_DECOUPLER) += pr-decoupler.o
> > +obj-$(CONFIG_FPGA_MGR_XILINX_SPI) += spi.o
> You just renamed the module to be called "spi.ko"????
>
> Did you test this thing?  You can not rename modules without good
> reasons, and calling a device specific kernel module "spi.ko" is not ok.

yes, this is a problem, I will drop the renaming patches.

Tom

> greg k-h