Re: [PATCH] mailbox: bcm2835: Remove redundant dev_err call in bcm2835_mbox_probe()

[Zhihao Cheng]

在 2021/6/1 16:24, Zhihao Cheng 写道:
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: Zhihao Cheng <chengzhihao1@xxxxxxxxxx>
> ---
>   drivers/mailbox/bcm2835-mailbox.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mailbox/bcm2835-mailbox.c b/drivers/mailbox/bcm2835-mailbox.c
> index 39761d190545..86b7ce3549c5 100644
> --- a/drivers/mailbox/bcm2835-mailbox.c
> +++ b/drivers/mailbox/bcm2835-mailbox.c
> @@ -157,7 +157,6 @@ static int bcm2835_mbox_probe(struct platform_device *pdev)
>   	mbox->regs = devm_ioremap_resource(&pdev->dev, iomem);
>   	if (IS_ERR(mbox->regs)) {
>   		ret = PTR_ERR(mbox->regs);
> -		dev_err(&pdev->dev, "Failed to remap mailbox regs: %d\n", ret);
>   		return ret;
>   	}
>   

friendly ping.