Re: [PATCH] nvme: NVME_TCP_OFFLOAD should not default to m

From: Geert Uytterhoeven
Date: Tue Jun 08 2021 - 09:38:17 EST


Hi Christoph,

On Tue, Jun 8, 2021 at 2:19 PM Christoph Hellwig <hch@xxxxxx> wrote:
> On Tue, Jun 08, 2021 at 12:56:09PM +0200, Geert Uytterhoeven wrote:
> > The help text for the symbol controlling support for the NVM Express
> > over Fabrics TCP offload common layer suggests to not enable this
> > support when unsure.
> >
> > Hence drop the "default m", which actually means "default y" if
> > CONFIG_MODULES is not enabled.
> >
> > Fixes: f0e8cb6106da2703 ("nvme-tcp-offload: Add nvme-tcp-offload - NVMeTCP HW offload ULP")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>
> Err, where did this appear from? This code has not been accepted into
> the NVMe tree and is indeed not acceptable in this form.

It was applied to net-next.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds