Re: [PATCH] regulator: bd71815: Get rid of struct bd71815_pmic

[Vaittinen, Matti]

On Mon, 2021-06-07 at 22:30 +0800, Axel Lin wrote:
> The content of bd71815_regulators is never changed, no need to
> duplicate
> it, thus remove descs[BD71815_REGULATOR_CNT].
> The *regmap, *dev and *rdev[BD71815_REGULATOR_CNT] are not really
> needed.
> The *gps is unused.
> 
> Thus the struct bd71815_pmic can be removed.
> 
> Signed-off-by: Axel Lin <axel.lin@xxxxxxxxxx>
> ---
>  drivers/regulator/bd71815-regulator.c | 57 +++++++++--------------
> ----
>  1 file changed, 19 insertions(+), 38 deletions(-)

Thanks a lot Axel. This is nice!

We might need to decide the ops for LDO3 based on a DT configuration
because the LDO3 state can be tied to DCIN connection. Currently the
driver does not support that though - and this patch is a nice
simplification!

Reviewed-by: Matti Vaittinen <matti.vaittinen@xxxxxxxxxxxxxxxxx>

Best Regards
	--Matti

Attachment: signature.asc
Description: This is a digitally signed message part