Re: [PATCH v7 2/4] Documentation: devres: Add pcim_alloc_irq_vectors()

From: Andy Shevchenko
Date: Mon Jun 07 2021 - 12:17:17 EST


On Mon, Jun 07, 2021 at 11:39:14PM +0800, Dejin Zheng wrote:
> Add pcim_alloc_irq_vectors(), a device-managed version of
> pci_alloc_irq_vectors(). introducing this function can simplify
> the error handling path in many drivers.

This is good one, thanks.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

> Reviewed-by: Robert Richter <rric@xxxxxxxxxx>
> Signed-off-by: Dejin Zheng <zhengdejin5@xxxxxxxxx>
> ---
> v6 -> v7:
> - rebase to PCI next branch
> v5 -> v6:
> - rebase to 5.13-rc4
> v4 -> v5:
> - No change
> v3 -> v4:
> - No change
> v2 -> v3:
> - No change
> v1 -> v2:
> - Modify some commit messages.
>
> Documentation/driver-api/driver-model/devres.rst | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/driver-api/driver-model/devres.rst b/Documentation/driver-api/driver-model/devres.rst
> index e0814d214048..fad7d26ccf35 100644
> --- a/Documentation/driver-api/driver-model/devres.rst
> +++ b/Documentation/driver-api/driver-model/devres.rst
> @@ -382,6 +382,7 @@ PCI
> devm_pci_alloc_host_bridge() : managed PCI host bridge allocation
> devm_pci_remap_cfgspace() : ioremap PCI configuration space
> devm_pci_remap_cfg_resource() : ioremap PCI configuration space resource
> + pcim_alloc_irq_vectors() : managed IRQ vectors allocation
> pcim_enable_device() : after success, all PCI ops become managed
> pcim_pin_device() : keep PCI device enabled after release
>
> --
> 2.30.1
>

--
With Best Regards,
Andy Shevchenko