Re: [PATCH v2 1/3] units: Add SI metric prefix definitions

From: Joe Perches
Date: Mon Jun 07 2021 - 12:00:47 EST


On Mon, 2021-06-07 at 18:57 +0300, Andy Shevchenko wrote:
> On Mon, Jun 07, 2021 at 08:43:02AM -0700, Joe Perches wrote:
> > On Mon, 2021-06-07 at 18:23 +0300, Andy Shevchenko wrote:
> > > Sometimes it's useful to have well-defined SI metric prefix to be used
> > > to self-describe the formulas or equations.
-=
> > The only use of any of these seems to be:
> >
> > sound/pcmcia/vx/vxp_ops.c: [VX_MICRO] = 0x0c, // MICRO
> > sound/pcmcia/vx/vxp_ops.c: vx_outb(chip, MICRO, level);
> > sound/pcmcia/vx/vxp_ops.c: vx_outb(chip, MICRO, vx_compute_mic_level(chip->mic_level));
> >
> > and these vx_outb uses are themselves macros that prepend VX_ to the 2nd arg.
>
> Is it a real issue there?

No, it's all good.